Merge cgogn:~kraemer/CGoGN

SCHNApps/CMakeLists.txt

@@ -73,6 +73,7 @@ SET (EXT_INCLUDES
 # define libs for external libs
 SET (EXT_LIBS 
 	PythonQt
+	nl
 	${OPENGL_LIBRARY}
 	${GLEW_LIBRARIES}
 	${ZLIB_LIBRARIES}
@@ -111,6 +112,7 @@ file(
 	SCHNApps_FILES
 	${SCHNApps_ROOT_DIR}/src/*.cpp
 	${SCHNApps_ROOT_DIR}/include/*.h
+	${SCHNApps_ROOT_DIR}/include/*.hpp
 )
 
 file(

SCHNApps/Plugins/differentialProperties/include/computeCurvatureDialog.h

@@ -24,9 +24,10 @@ private:
 	MapHandlerGen* m_selectedMap;
 
 public slots:
-	void refreshUI();
+	void selectedMapChanged();
 	void addMapToList(MapHandlerGen* m);
 	void removeMapFromList(MapHandlerGen* m);
+	void addAttributeToList(unsigned int orbit, const QString& nameAttr);
 };
 
 } // namespace SCHNApps

SCHNApps/Plugins/differentialProperties/include/computeNormalDialog.h

@@ -24,9 +24,12 @@ private:
 	MapHandlerGen* m_selectedMap;
 
 public slots:
-	void refreshUI();
+	void selectedMapChanged();
 	void addMapToList(MapHandlerGen* m);
 	void removeMapFromList(MapHandlerGen* m);
+	void addAttributeToList(unsigned int orbit, const QString& nameAttr);
+
+	void attributeModified(unsigned int orbit, QString nameAttr);
 };
 
 } // namespace SCHNApps

SCHNApps/Plugins/differentialProperties/include/differentialProperties.h

@@ -72,6 +72,15 @@ private:
 
 	QAction* m_computeNormalAction;
 	QAction* m_computeCurvatureAction;
+
+	struct ComputeNormalParameters
+	{
+		ComputeNormalParameters() {}
+		ComputeNormalParameters(QString p, QString n) : positionName(p), normalName(n) {}
+		QString positionName;
+		QString normalName;
+	};
+	QHash<QString, ComputeNormalParameters> computeNormalLastParameters;
 };
 
 #endif

SCHNApps/Plugins/differentialProperties/src/computeCurvatureDialog.cpp

@@ -25,17 +25,17 @@ ComputeCurvatureDialog::ComputeCurvatureDialog(Window* w) :
 	connect(m_window, SIGNAL(mapAdded(MapHandlerGen*)), this, SLOT(addMapToList(MapHandlerGen*)));
 	connect(m_window, SIGNAL(mapRemoved(MapHandlerGen*)), this, SLOT(removeMapFromList(MapHandlerGen*)));
 
-	connect(mapList, SIGNAL(itemSelectionChanged()), this, SLOT(refreshUI()));
+	connect(mapList, SIGNAL(itemSelectionChanged()), this, SLOT(selectedMapChanged()));
 
 	const QList<MapHandlerGen*>& maps = m_window->getMapsList();
 	foreach(MapHandlerGen* map, maps)
 		mapList->addItem(map->getName());
 }
 
-void ComputeCurvatureDialog::refreshUI()
+void ComputeCurvatureDialog::selectedMapChanged()
 {
 	if(m_selectedMap)
-		disconnect(m_selectedMap, SIGNAL(attributeAdded()), this, SLOT(refreshUI()));
+		disconnect(m_selectedMap, SIGNAL(attributeAdded(unsigned int, const QString&)), this, SLOT(addAttributeToList(unsigned int, const QString&)));
 
 	QList<QListWidgetItem*> currentItems = mapList->selectedItems();
 	if(!currentItems.empty())
@@ -47,53 +47,50 @@ void ComputeCurvatureDialog::refreshUI()
 		combo_KnormalAttribute->clear();
 		combo_kmaxAttribute->clear();
 		combo_kminAttribute->clear();
+
 		const QString& mapname = currentItems[0]->text();
 		MapHandlerGen* mh = m_window->getMap(mapname);
-		GenericMap* map = mh->getGenericMap();
-		AttributeContainer& cont = map->getAttributeContainer<VERTEX>();
-
-		std::vector<std::string> names;
-		std::vector<std::string> types;
-		cont.getAttributesNames(names);
-		cont.getAttributesTypes(types);
-		std::string vec3TypeName = nameOfType(PFP2::VEC3());
-		std::string realTypeName = nameOfType(PFP2::REAL());
+
+		QString vec3TypeName = QString::fromStdString(nameOfType(PFP2::VEC3()));
+		QString realTypeName = QString::fromStdString(nameOfType(PFP2::REAL()));
+
 		unsigned int j = 0;
 		unsigned int k = 0;
-		for(unsigned int i = 0; i < names.size(); ++i)
+		const AttributeHash& attribs = mh->getAttributesList(VERTEX);
+		for(AttributeHash::const_iterator i = attribs.constBegin(); i != attribs.constEnd(); ++i)
 		{
-			if(types[i] == vec3TypeName)
+			if(i.value() == vec3TypeName)
 			{
-				combo_positionAttribute->addItem(QString::fromStdString(names[i]));
-				if(names[i] == "position") // try to select a position attribute named "position"
+				combo_positionAttribute->addItem(i.key());
+				if(i.key() == "position") // try to select a position attribute named "position"
 					combo_positionAttribute->setCurrentIndex(j);
 
-				combo_normalAttribute->addItem(QString::fromStdString(names[i]));
-				if(names[i] == "normal") // try to select a normal attribute named "normal"
+				combo_normalAttribute->addItem(i.key());
+				if(i.key() == "normal") // try to select a normal attribute named "normal"
 					combo_normalAttribute->setCurrentIndex(j);
 
-				combo_KmaxAttribute->addItem(QString::fromStdString(names[i]));
-				if(names[i] == "Kmax") // try to select a normal attribute named "Kmax"
+				combo_KmaxAttribute->addItem(i.key());
+				if(i.key() == "Kmax") // try to select a normal attribute named "Kmax"
 					combo_KmaxAttribute->setCurrentIndex(j);
 
-				combo_KminAttribute->addItem(QString::fromStdString(names[i]));
-				if(names[i] == "Kmin") // try to select a normal attribute named "Kmin"
+				combo_KminAttribute->addItem(i.key());
+				if(i.key() == "Kmin") // try to select a normal attribute named "Kmin"
 					combo_KminAttribute->setCurrentIndex(j);
 
-				combo_KnormalAttribute->addItem(QString::fromStdString(names[i]));
-				if(names[i] == "Knormal") // try to select a normal attribute named "Knormal"
+				combo_KnormalAttribute->addItem(i.key());
+				if(i.key() == "Knormal") // try to select a normal attribute named "Knormal"
 					combo_KnormalAttribute->setCurrentIndex(j);
 
 				++j;
 			}
-			else if(types[i] == realTypeName)
+			else if(i.value() == realTypeName)
 			{
-				combo_kmaxAttribute->addItem(QString::fromStdString(names[i]));
-				if(names[i] == "kmax") // try to select a normal attribute named "kmax"
+				combo_kmaxAttribute->addItem(i.key());
+				if(i.key() == "kmax") // try to select a normal attribute named "kmax"
 					combo_kmaxAttribute->setCurrentIndex(k);
 
-				combo_kminAttribute->addItem(QString::fromStdString(names[i]));
-				if(names[i] == "kmin") // try to select a normal attribute named "kmin"
+				combo_kminAttribute->addItem(i.key());
+				if(i.key() == "kmin") // try to select a normal attribute named "kmin"
 					combo_kminAttribute->setCurrentIndex(k);
 
 				++k;
@@ -101,7 +98,7 @@ void ComputeCurvatureDialog::refreshUI()
 		}
 
 		m_selectedMap = mh;
-		connect(m_selectedMap, SIGNAL(attributeAdded()), this, SLOT(refreshUI()));
+		connect(m_selectedMap, SIGNAL(attributeAdded(unsigned int, const QString&)), this, SLOT(addAttributeToList(unsigned int, const QString&)));
 	}
 	else
 		m_selectedMap = NULL;
@@ -120,11 +117,33 @@ void ComputeCurvatureDialog::removeMapFromList(MapHandlerGen* m)
 
 	if(m_selectedMap == m)
 	{
-		disconnect(m_selectedMap, SIGNAL(attributeAdded()), this, SLOT(refreshUI()));
+		disconnect(m_selectedMap, SIGNAL(attributeAdded(unsigned int, const QString&)), this, SLOT(addAttributeToList(unsigned int, const QString&)));
 		m_selectedMap = NULL;
 	}
 }
 
+void ComputeCurvatureDialog::addAttributeToList(unsigned int orbit, const QString& nameAttr)
+{
+	QString vec3TypeName = QString::fromStdString(nameOfType(PFP2::VEC3()));
+	QString realTypeName = QString::fromStdString(nameOfType(PFP2::REAL()));
+
+	const QString& typeAttr = m_selectedMap->getAttributeTypeName(orbit, nameAttr);
+
+	if(typeAttr == vec3TypeName)
+	{
+		combo_positionAttribute->addItem(nameAttr);
+		combo_normalAttribute->addItem(nameAttr);
+		combo_KmaxAttribute->addItem(nameAttr);
+		combo_KminAttribute->addItem(nameAttr);
+		combo_KnormalAttribute->addItem(nameAttr);
+	}
+	else if(typeAttr == realTypeName)
+	{
+		combo_kmaxAttribute->addItem(nameAttr);
+		combo_kminAttribute->addItem(nameAttr);
+	}
+}
+
 } // namespace SCHNApps
 
 } // namespace CGoGN

SCHNApps/Plugins/differentialProperties/src/computeNormalDialog.cpp

@@ -21,44 +21,45 @@ ComputeNormalDialog::ComputeNormalDialog(Window* w) :
 	connect(m_window, SIGNAL(mapAdded(MapHandlerGen*)), this, SLOT(addMapToList(MapHandlerGen*)));
 	connect(m_window, SIGNAL(mapRemoved(MapHandlerGen*)), this, SLOT(removeMapFromList(MapHandlerGen*)));
 
-	connect(mapList, SIGNAL(itemSelectionChanged()), this, SLOT(refreshUI()));
+	connect(mapList, SIGNAL(itemSelectionChanged()), this, SLOT(selectedMapChanged()));
 
 	const QList<MapHandlerGen*>& maps = m_window->getMapsList();
 	foreach(MapHandlerGen* map, maps)
-		mapList->addItem(map->getName());
+	{
+		QListWidgetItem* item = new QListWidgetItem(map->getName(), mapList);
+		item->setCheckState(Qt::Unchecked);
+		connect(map, SIGNAL(attributeModified(unsigned int, QString)), this, SLOT(attributeModified(unsigned int, QString)));
+	}
 }
 
-void ComputeNormalDialog::refreshUI()
+void ComputeNormalDialog::selectedMapChanged()
 {
 	if(m_selectedMap)
-		disconnect(m_selectedMap, SIGNAL(attributeAdded()), this, SLOT(refreshUI()));
+		disconnect(m_selectedMap, SIGNAL(attributeAdded(unsigned int, const QString&)), this, SLOT(addAttributeToList(unsigned int, const QString&)));
 
 	QList<QListWidgetItem*> currentItems = mapList->selectedItems();
 	if(!currentItems.empty())
 	{
 		combo_positionAttribute->clear();
 		combo_normalAttribute->clear();
+
 		const QString& mapname = currentItems[0]->text();
 		MapHandlerGen* mh = m_window->getMap(mapname);
-		GenericMap* map = mh->getGenericMap();
-		AttributeContainer& cont = map->getAttributeContainer<VERTEX>();
-
-		std::vector<std::string> names;
-		std::vector<std::string> types;
-		cont.getAttributesNames(names);
-		cont.getAttributesTypes(types);
-		std::string vec3TypeName = nameOfType(PFP2::VEC3());
+
+		QString vec3TypeName = QString::fromStdString(nameOfType(PFP2::VEC3()));
+
 		unsigned int j = 0;
-		for(unsigned int i = 0; i < names.size(); ++i)
+		const AttributeHash& attribs = mh->getAttributesList(VERTEX);
+		for(AttributeHash::const_iterator i = attribs.constBegin(); i != attribs.constEnd(); ++i)
 		{
-			if(types[i] == vec3TypeName)
+			if(i.value() == vec3TypeName)
 			{
-				combo_positionAttribute->addItem(QString::fromStdString(names[i]));
-				if(names[i] == "position") // try to select a position attribute named "position"
+				combo_positionAttribute->addItem(i.key());
+				if(i.key() == "position") // try to select a position attribute named "position"
 					combo_positionAttribute->setCurrentIndex(j);
 
-				combo_normalAttribute->addItem(QString::fromStdString(names[i]));
-				if(names[i] == "normal") // try to select a normal attribute named "normal"
+				combo_normalAttribute->addItem(i.key());
+				if(i.key() == "normal") // try to select a normal attribute named "normal"
 					combo_normalAttribute->setCurrentIndex(j);
 
 				++j;
@@ -66,7 +67,7 @@ void ComputeNormalDialog::refreshUI()
 		}
 
 		m_selectedMap = mh;
-		connect(m_selectedMap, SIGNAL(attributeAdded()), this, SLOT(refreshUI()));
+		connect(m_selectedMap, SIGNAL(attributeAdded(unsigned int, const QString&)), this, SLOT(addAttributeToList(unsigned int, const QString&)));
 	}
 	else
 		m_selectedMap = NULL;
@@ -74,7 +75,8 @@ void ComputeNormalDialog::refreshUI()
 
 void ComputeNormalDialog::addMapToList(MapHandlerGen* m)
 {
-	mapList->addItem(m->getName());
+	QListWidgetItem* item = new QListWidgetItem(m->getName(), mapList);
+	item->setCheckState(Qt::Unchecked);
 }
 
 void ComputeNormalDialog::removeMapFromList(MapHandlerGen* m)
@@ -85,11 +87,33 @@ void ComputeNormalDialog::removeMapFromList(MapHandlerGen* m)
 
 	if(m_selectedMap == m)
 	{
-		disconnect(m_selectedMap, SIGNAL(attributeAdded()), this, SLOT(refreshUI()));
+		disconnect(m_selectedMap, SIGNAL(attributeAdded(unsigned int, const QString&)), this, SLOT(addAttributeToList(unsigned int, const QString&)));
 		m_selectedMap = NULL;
 	}
 }
 
+void ComputeNormalDialog::addAttributeToList(unsigned int orbit, const QString& nameAttr)
+{
+	QString vec3TypeName = QString::fromStdString(nameOfType(PFP2::VEC3()));
+
+	const QString& typeAttr = m_selectedMap->getAttributeTypeName(orbit, nameAttr);
+
+	if(typeAttr == vec3TypeName)
+	{
+		combo_positionAttribute->addItem(nameAttr);
+		combo_normalAttribute->addItem(nameAttr);
+	}
+}
+
+void ComputeNormalDialog::attributeModified(unsigned int orbit, QString nameAttr)
+{
+	MapHandlerGen* map = static_cast<MapHandlerGen*>(QObject::sender());
+//	if(orbit == VERTEX && nameAttr == )
+//	{
+
+//	}
+}
+
 } // namespace SCHNApps
 
 } // namespace CGoGN

SCHNApps/Plugins/differentialProperties/src/differentialProperties.cpp

@@ -139,6 +139,9 @@ void DifferentialPropertiesPlugin::computeNormal(
 	if(createNormalVBO)
 		mh->createVBO(normal);
 
+	computeNormalLastParameters[mapName] =
+		ComputeNormalParameters(positionAttributeName, normalAttributeName) ;
+
 	QList<View*> views = mh->getLinkedViews();
 	foreach(View* view, views)
 		view->updateGL();

SCHNApps/Plugins/importSurface/src/importSurface.cpp

@@ -27,10 +27,11 @@ MapHandlerGen* ImportSurfacePlugin::importFromFile(const QString& fileName)
 			PFP2::MAP* map = mh->getMap();
 
 			std::vector<std::string> attrNames;
-			Algo::Surface::Import::importMesh<PFP2>(*map, fileName.toUtf8().constData(), attrNames);
+			Algo::Surface::Import::importMesh<PFP2>(*map, fileName.toStdString(), attrNames);
 
 			// get vertex position attribute
 			VertexAttribute<PFP2::VEC3> position = map->getAttribute<PFP2::VEC3, CGoGN::VERTEX>(attrNames[0]);
+			mh->registerAttribute<PFP2::VEC3, VERTEX>(position);
 
 			// create VBO for vertex position attribute
 			mh->createVBO(position);

SCHNApps/Plugins/importVolume/src/importVolume.cpp

@@ -27,10 +27,11 @@ MapHandlerGen* ImportVolumePlugin::importFromFile(const QString& fileName)
 			PFP3::MAP* map = mh->getMap();
 
 			std::vector<std::string> attrNames ;
-			Algo::Volume::Import::importMesh<PFP3>(*map, fileName.toUtf8().constData(), attrNames);
+			Algo::Volume::Import::importMesh<PFP3>(*map, fileName.toStdString(), attrNames);
 
 			// get vertex position attribute
 			VertexAttribute<PFP3::VEC3> position = map->getAttribute<PFP3::VEC3, CGoGN::VERTEX>(attrNames[0]);
+			mh->registerAttribute<PFP2::VEC3, VERTEX>(position);
 
 			// create VBO for vertex position attribute
 			mh->createVBO(position);

SCHNApps/Plugins/render/CMakeLists.txt

@@ -26,6 +26,7 @@ file(
 SET(
 	PLUGIN_QOBJECT_FILES
 	${PLUGIN_ROOT_DIR}/include/render.h
+	${PLUGIN_ROOT_DIR}/include/renderDockTab.h
 )
 
 include( ${SCHNApps_ROOT_DIR}/Plugins/plugins_cmake.txt )

SCHNApps/Plugins/render/forms/render.ui

 <?xml version="1.0" encoding="UTF-8"?>
 <ui version="4.0">
- <class>RenderWidget</class>
- <widget class="QWidget" name="RenderWidget">
+ <class>RenderDockWidget</class>
+ <widget class="QWidget" name="RenderDockWidget">
   <property name="geometry">
    <rect>
     <x>0</x>
     <y>0</y>
     <width>174</width>
-    <height>547</height>
+    <height>545</height>
    </rect>
   </property>
   <property name="windowTitle">

SCHNApps/Plugins/render/include/render.h

@@ -2,17 +2,18 @@
 #define _RENDER_PLUGIN_H_
 
 #include "plugin.h"
-#include "ui_render.h"
+#include "renderDockTab.h"
 
 #include "Utils/Shaders/shaderFlat.h"
 #include "Utils/Shaders/shaderPhong.h"
 #include "Utils/Shaders/shaderSimpleColor.h"
 #include "Utils/pointSprite.h"